Skip to content

feat(cpp): add functions related to system#3102

Merged
hubcio merged 17 commits into
apache:masterfrom
slbotbm:cpp-system-functions
May 25, 2026
Merged

feat(cpp): add functions related to system#3102
hubcio merged 17 commits into
apache:masterfrom
slbotbm:cpp-system-functions

Conversation

@slbotbm
Copy link
Copy Markdown
Contributor

@slbotbm slbotbm commented Apr 12, 2026 •
edited
Loading

Which issue does this PR close?

Works toward completion of #2100

Rationale

This PR adds functions related to the system, and tests for previously untested functions.

What changed?

This PR adds:

  • The following functions and their tests:
    • get_stats
    • get_me
    • get_client
    • get_clients
    • ping
    • heartbeat_interval
    • snapshot

The places labelled TODO will be completed after merging of #3046.

Local Execution

  • Passed
  • Pre-commit hooks ran

AI Usage

If AI tools were used, please answer:

  1. Which tools? (e.g., GitHub Copilot, Claude, ChatGPT) codex
  2. Scope of usage? (e.g., autocomplete, generated functions, entire implementation) code generation based on explicit instructions given by me.
  3. How did you verify the generated code works correctly? ran the tests, read through and understood the generated code
  4. Can you explain every line of the code if asked? yes

@slbotbm slbotbm marked this pull request as draft April 12, 2026 14:29
@slbotbm slbotbm changed the title feata(cpp): add functions related to system, tests for purge_* functions, and consumer group functions (WIP) feat(cpp): add functions related to system, tests for purge_* functions, and consumer group functions (WIP) Apr 12, 2026
@slbotbm slbotbm marked this pull request as ready for review April 22, 2026 11:19
@slbotbm
Copy link
Copy Markdown
Contributor Author

slbotbm commented Apr 22, 2026

This PR is ready for review

@slbotbm slbotbm changed the title feat(cpp): add functions related to system, tests for purge_* functions, and consumer group functions (WIP) feat(cpp): add functions related to system Apr 25, 2026
hubcio
hubcio requested changes Apr 29, 2026
View reviewed changes
Comment thread foreign/cpp/src/client.rs
Comment thread foreign/cpp/src/client.rs
Comment thread foreign/cpp/src/lib.rs
Comment thread foreign/cpp/src/lib.rs
Comment thread foreign/cpp/src/lib.rs
Comment thread foreign/cpp/tests/client/low_level_e2e.cpp Outdated
Comment thread foreign/cpp/tests/client/low_level_e2e.cpp
Comment thread foreign/cpp/tests/client/low_level_e2e.cpp
Comment thread foreign/cpp/tests/client/low_level_e2e.cpp Outdated
Comment thread foreign/cpp/build.rs Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either @core on Discord or by mentioning them directly here on the PR.

Thank you for your contribution!

@github-actions github-actions Bot added the S-stale Inactive issue or pull request label May 8, 2026
@slbotbm slbotbm marked this pull request as draft May 10, 2026 14:39
@slbotbm slbotbm force-pushed the cpp-system-functions branch from c6be262 to 4e2082a Compare May 11, 2026 13:23
@hubcio
Copy link
Copy Markdown
Contributor

hubcio commented May 14, 2026

/ready

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label May 14, 2026
@slbotbm
Copy link
Copy Markdown
Contributor Author

slbotbm commented May 14, 2026 •
edited
Loading

@hubcio i still need to completely address the review for this pr

maybe /author is better?

@hubcio
Copy link
Copy Markdown
Contributor

hubcio commented May 14, 2026 •
edited
Loading

@slbotbm I know. /ready is me marking the PR ready for review. see CONTRIBUTING.md - i added simple triage bot. this PR was created before the bot, so I'm marking manually all existing PRs.

EDIT: you are right! this should be /author...

@hubcio
Copy link
Copy Markdown
Contributor

hubcio commented May 14, 2026

/author

@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels May 14, 2026
@slbotbm slbotbm marked this pull request as ready for review May 16, 2026 08:01
@slbotbm
Copy link
Copy Markdown
Contributor Author

slbotbm commented May 16, 2026

/ready

@github-actions github-actions Bot added S-waiting-on-review PR is waiting on a reviewer and removed S-waiting-on-author PR is waiting on author response S-stale Inactive issue or pull request labels May 16, 2026
hubcio
hubcio requested changes May 20, 2026
View reviewed changes
Comment thread foreign/cpp/src/client.rs
Comment thread foreign/cpp/include/iggy.hpp Outdated
Comment thread foreign/cpp/include/iggy.hpp Outdated
Comment thread foreign/cpp/src/identifier.rs Outdated
Comment thread foreign/cpp/src/lib.rs Outdated
Comment thread foreign/cpp/src/client.rs Outdated
Comment thread foreign/cpp/tests/client/low_level_e2e.cpp
Comment thread foreign/cpp/tests/client/low_level_e2e.cpp Outdated
Comment thread foreign/cpp/src/client.rs
Comment thread foreign/cpp/src/client.rs
@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels May 20, 2026
amlel-el-mahrouss
amlel-el-mahrouss reviewed May 21, 2026
View reviewed changes
Comment thread foreign/cpp/include/iggy.hpp
amlel-el-mahrouss
amlel-el-mahrouss reviewed May 21, 2026
View reviewed changes
Comment thread foreign/cpp/include/iggy.hpp
amlel-el-mahrouss
amlel-el-mahrouss suggested changes May 21, 2026
View reviewed changes
Copy link
Copy Markdown

@amlel-el-mahrouss amlel-el-mahrouss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting the following changes for:

  • StringType
  • SnapshotCompression

See the comments for more info.

@slbotbm
Copy link
Copy Markdown
Contributor Author

slbotbm commented May 23, 2026

/ready

@github-actions github-actions Bot added S-waiting-on-review PR is waiting on a reviewer and removed S-waiting-on-author PR is waiting on author response labels May 23, 2026
@hubcio hubcio merged commit 115ac21 into apache:master May 25, 2026
30 checks passed
@github-actions github-actions Bot removed the S-waiting-on-review PR is waiting on a reviewer label May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hubcio hubcio hubcio approved these changes

@mmodzelewski mmodzelewski mmodzelewski approved these changes

+1 more reviewer

@amlel-el-mahrouss amlel-el-mahrouss amlel-el-mahrouss requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@slbotbm @hubcio @mmodzelewski @amlel-el-mahrouss